Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

login button #9

Merged
merged 2 commits into from
Jan 24, 2025
Merged

login button #9

merged 2 commits into from
Jan 24, 2025

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Jan 17, 2025 •
edited
Loading

Short description of the changes:

The login button is updated to always open, due to shiver related changes in logic

Long description of the changes:

updates in the source code and tests.

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

[SHIVER] OnCat -  Connection Status functionality update

@mpatrou mpatrou mentioned this pull request Jan 17, 2025
Merged
13 tasks
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.07%. Comparing base (554fb9b) to head (a5ef1f8).

Additional details and impacted files 
@@            Coverage Diff             @@
##             next       #9      +/-   ##
==========================================
+ Coverage   93.75%   95.07%   +1.32%     
==========================================
  Files           3        3              
  Lines         144      142       -2     
==========================================
  Hits          135      135              
+ Misses          9        7       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpatrou mpatrou merged commit bde2dce into next Jan 24, 2025
3 checks passed
@mpatrou mpatrou deleted the login_button branch January 24, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreiSavici AndreiSavici AndreiSavici approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpatrou @codecov-commenter @AndreiSavici